fix: push docker image action. #580
Conversation
Signed-off-by: zemyblue <[email protected]>
Signed-off-by: zemyblue <[email protected]>
Signed-off-by: zemyblue <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 57.68% 57.68% -0.01%
==========================================
Files 793 793
Lines 87013 87013
==========================================
- Hits 50193 50190 -3
- Misses 33662 33664 +2
- Partials 3158 3159 +1
|
| @@ -30,7 +30,7 @@ RUN make build-linux | |||
| FROM alpine:edge | |||
|
|
|||
| # Install ca-certificates | |||
| RUN apk add --update ca-certificates | |||
| RUN apk add --update ca-certificates libstdc++ | |||
There was a problem hiding this comment.
Is this change specific to M1? Then, it would be nice to state it in the comment or description of the PR.
There was a problem hiding this comment.
I know it is for using BLS of line/ostracon.
There was a problem hiding this comment.
I tried it on M1 macbook docker linux/arm64 and linux/amd64 environment, but the latest github.com/herumi/bls-eth-go-binary seems to require libstdc++.
There was a problem hiding this comment.
No, libstdc++ library is required for linux/amd64 because bls-eth-go-binary of ostracon.
I add the description about this chagens.
go.mod
Outdated
| @@ -62,5 +62,6 @@ require ( | |||
| replace ( | |||
| github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76 | |||
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
| github.com/herumi/bls-eth-go-binary => github.com/herumi/bls-eth-go-binary v0.0.0-20220509081320-2d8ab06de53c | |||
There was a problem hiding this comment.
How about using line/ostracon-v1.0.6 instead of using replace?
There was a problem hiding this comment.
How about using line/ostracon-v1.0.6 instead of using replace?
I think so, too.
There was a problem hiding this comment.
Thank you. I'll change line/ostracon version from v1.0.6-0.20220614053335-f9d9fa2cc779 to v1.0.6. However this change would not have been necessary in the original. :)
Signed-off-by: zemyblue <[email protected]>
Signed-off-by: zemyblue [email protected]
Description
The registered docker image of docker hub is not executed in Apple M1 Macbook. Because the docker image was not built with the
platformsinformation, so I fix this problem in this PR.And
libstdc++library is required forlinux/amd64becausebls-eth-go-binaryofostracon. So I add it in theDockerfile.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml