Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore norace tag #516

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Apr 27, 2022

Description

After bumping up to [email protected], errors frequently occur in the data race. in the process of work
I deleted the build tag for debugging, but it seems that an error like this occurred because it was not restored.
I restored the build tag because the test code in server/grpc did not take the data race into account.

closes: #514

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added the A: bug Something isn't working label Apr 27, 2022
@dudong2 dudong2 requested review from zemyblue and 0Tech April 27, 2022 08:29
@dudong2 dudong2 self-assigned this Apr 27, 2022
@dudong2 dudong2 requested a review from loin3 April 27, 2022 08:30
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #516 (ead9635) into main (396a1fe) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   56.75%   56.76%           
=======================================
  Files         777      777           
  Lines       83389    83389           
=======================================
+ Hits        47331    47333    +2     
+ Misses      33004    33003    -1     
+ Partials     3054     3053    -1     
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/wasm/keeper/keeper.go 85.22% <0.00%> (+0.36%) ⬆️

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@zemyblue
Copy link
Member

@dudong2, please add changelog

@dudong2 dudong2 merged commit f3aa55f into Finschia:main Apr 28, 2022
@dudong2 dudong2 deleted the dudong2/test/norace-tag branch April 28, 2022 04:18
@zemyblue zemyblue mentioned this pull request Apr 28, 2022
4 tasks
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data race error
3 participants