feat: rewrite issue template and move PR template #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Dec 23, 2021
| - [ ] Review `Codecov Report` in the comment section below once CI passes | ||
| ## Checklist: | ||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> |
There was a problem hiding this comment.
How about adding next?
- I have added a relevant changelog to
CHANGELOG.md - I have updated API documentation (client/docs/swagger-ui/swagger.yaml)
brew0722
reviewed
Jan 7, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] I have added a relevant changelog to `CHANGELOG.md` | ||
| - [ ] I have added tests to cover my changes. | ||
| - [ ] I have updated the documentation accordingly. | ||
| - [ ] I have updated API documentation (client/docs/swagger-ui/swagger.yaml). |
There was a problem hiding this comment.
client/docs/swagger-ui/swagger.yaml
It is seems in plain text. It doesn't seem to be recognized as a hyperlink path. Do you know the cause? I think it cause missed the '[... ]' before '(...)'.
There was a problem hiding this comment.
This is intended. This is because contributors need only to read contributing guidelines and code of conduct, and they need to fix API documentation.
There was a problem hiding this comment.
I understand the intent is different. Then you don't need hyperlinks.
Then, wouldn't it be necessary to write it like CHANGELOG.md?
brew0722
approved these changes
Jan 17, 2022
zemyblue
added a commit
that referenced
this pull request
Jan 25, 2022
* main: (44 commits) feat: rewrite issue template and move PR template (#410) fix: validate validator addresses in update-validator-auths proposal (#411) feat: add `bankplus` function to restrict to send coin to inactive smart contract. (#400) build(deps): bump actions/setup-go from 2.1.4 to 2.1.5 (#408) ci: fix branch name on ci script (#409) feat: Add CreateValidator access control feature (#406) build(deps): bump github.com/spf13/viper from 1.9.0 to 1.10.1 (#403) build(deps): bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (#402) fix: fix query signing infos command (#407) build(deps): bump github.com/spf13/cobra from 1.1.3 to 1.3.0 (#399) build(deps): github.com/ulikunitz/xz from 0.5.5 to 0.5.10 (#398) build(deps): bump actions/stale from 3 to 4.1.0 (#396) build(deps): bump actions/cache from 2.1.3 to 2.1.7 (#386) feat: Add the `instantiate_permission` in the `CodeInfoResponse` (#395) fix: fix bug where `StoreCodeAndInstantiateContract`, `UpdateContractStatus`, `UpdateContractStatusProposal` API does not work (#393) docs: modify with latest version of swagger REST interface docs. (#392) fix: fix invalid root hash by bumping up tm-db (#388) chore: fix swagger's config path for wasm (#391) build(deps): bump technote-space/get-diff-action from 5.0.1 to 5.0.2 (#379) fix: update allowance inside AllowedMsgAllowance (#383) ...
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #101
About PULL_REQUEST_TEMPLATE.md, this is moved from the top directory to .github directory.
Check the diff and tell me if needed checkboxes are deleted from the original.