Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update changelog #381

Merged
merged 1 commit into from
Nov 16, 2021
Merged

docs: update changelog #381

merged 1 commit into from
Nov 16, 2021

Conversation

brew0722
Copy link
Contributor

Description

closes: #358
missing update changelog for #358

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@brew0722 brew0722 added the documentation Improvements or additions to documentation label Nov 16, 2021
@brew0722 brew0722 self-assigned this Nov 16, 2021
shiki-tak
shiki-tak approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit 6d3d2f1 into Finschia:main Nov 16, 2021
@brew0722 brew0722 deleted the update-changelog branch November 16, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

Assignees

@brew0722 brew0722

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brew0722 @shiki-tak @loloicci