Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gov/weighted-vote #368

Merged
merged 2 commits into from
Nov 2, 2021
Merged

feat: add gov/weighted-vote #368

merged 2 commits into from
Nov 2, 2021

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Nov 1, 2021

Description

Added gov/weighted-vote features with reference to cosmos-sdk v0.43.0

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dudong2 dudong2 self-assigned this Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@b8a0281). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage        ?   53.22%           
=======================================
  Files           ?      644           
  Lines           ?    67619           
  Branches        ?        0           
=======================================
  Hits            ?    35990           
  Misses          ?    28675           
  Partials        ?     2954           

Copy link

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iproudhon iproudhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 8cec5b9 into Finschia:main Nov 2, 2021
@dudong2 dudong2 deleted the dudong2/feat/weighted-vote branch November 7, 2021 23:27
@zemyblue zemyblue mentioned this pull request Jan 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants