Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: introduce VoterSetCounter #347

Merged
merged 7 commits into from
Oct 14, 2021
Merged

fix: introduce VoterSetCounter #347

merged 7 commits into from
Oct 14, 2021

Commits on Oct 6, 2021

  1. feat: introduce VoterSetCounter 

    Introducing a concept "voter set counter" eases integration
with `ostracon`'s `VoterSet`.
    @0Tech
    0Tech committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    366dea6 View commit details
    Browse the repository at this point in the history

  2. fix: fix off-by-one error and add a test to catch it

    @0Tech
    0Tech committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    b914b62 View commit details
    Browse the repository at this point in the history

  3. refactor: change the meaning of VoteSetCounter 

    Now `VoteSetCounter` in HandleValidatorSignature indicates the real
counted number, not a index-like number.
    @0Tech
    0Tech committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    45d50ad View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. fix: check liveness threshold from the second round of the window 

    Check the liveness threshold only provided `VoterSetCounter >
SignedBlocksWindow` meaning `VoterSetCounter >= SignedBlocksWindow +
1`.
    @0Tech
    0Tech committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    6856809 View commit details
    Browse the repository at this point in the history

  2. chore: provide more meaningful log 

    Log `VoterSetCounter` instead of `minVoterSetCount` which is constant.
    @0Tech
    0Tech committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    3af603c View commit details
    Browse the repository at this point in the history

  3. style: correct typos

    @0Tech
    0Tech committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    b8fe202 View commit details
    Browse the repository at this point in the history

  4. Revert "fix: check liveness threshold from the second round of ..." 

    This reverts commit 6856809.
    @0Tech
    0Tech committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    43341a0 View commit details
    Browse the repository at this point in the history