Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send tx with unknown address with daemon command #286

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix: send tx with unknown address with daemon command #286

merged 1 commit into from
Jul 15, 2021

Conversation

egonspace
Copy link

Description

For now following command fails.

simd start
simd keys add test --keyring-backend test
simd tx auth empty [new_address] --keyring-backend test --chain-id sim
Error: {"codespace":"sdk","code":22,"message":"rpc error: code = NotFound desc = account [new_address] not found: key not found"}

I tested this at previous PR(#265) but I think I tested something wrong then.

This is a problem caused by mischecking the type of on error in the query response.
The type of error that is returned by accountRetriever.GetAccountSequence is not sdkerror.Error but client.Error.
I fixed it.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Jul 14, 2021
@egonspace egonspace added the A: bug Something isn't working label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c1c71f1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage        ?   53.33%           
=======================================
  Files           ?      639           
  Lines           ?    46816           
  Branches        ?        0           
=======================================
  Hits            ?    24969           
  Misses          ?    18995           
  Partials        ?     2852           

@egonspace egonspace merged commit 7ecb96e into Finschia:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants