feat: initialize fbridge module #1340

tkxkd0159 · 2024-04-23T14:52:24Z

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

codecov · 2024-04-24T04:37:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pjdp1@52a3f83). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff            @@
##             pjdp1    #1340   +/-   ##
========================================
  Coverage         ?   70.34%           
========================================
  Files            ?      657           
  Lines            ?    54977           
  Branches         ?        0           
========================================
  Hits             ?    38674           
  Misses           ?    14120           
  Partials         ?     2183

170210

Please check failed test

proto/lbm/fbridge/v1/fbridge.proto

proto/lbm/fbridge/v1/query.proto

jaeseung-bae

LGTM

proto/lbm/fbridge/v1/tx.proto

* feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]> * chore: lint fix --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

tkxkd0159 added 2 commits April 22, 2024 19:32

initialize fbridge module

a3aa280

add all proto files for fbridge

a25a71f

tkxkd0159 self-assigned this Apr 23, 2024

add missing proto files

1e6e34e

tkxkd0159 force-pushed the fbridge-init branch from bacb95f to 440b517 Compare April 24, 2024 07:11

chore

f958df5

tkxkd0159 force-pushed the fbridge-init branch from 440b517 to f958df5 Compare April 24, 2024 07:22

tkxkd0159 added 2 commits April 24, 2024 16:23

initialize module structure

038daf7

lint

115e37a

tkxkd0159 marked this pull request as ready for review April 24, 2024 07:30

tkxkd0159 requested review from zemyblue, 0Tech and jaeseung-bae as code owners April 24, 2024 07:30

tkxkd0159 requested a review from 170210 April 24, 2024 07:30

170210 reviewed Apr 24, 2024

View reviewed changes

proto/lbm/fbridge/v1/fbridge.proto Show resolved Hide resolved

proto/lbm/fbridge/v1/query.proto Show resolved Hide resolved

chore

045d683

tkxkd0159 requested a review from 170210 April 24, 2024 14:38

da1suk8 mentioned this pull request Apr 25, 2024

feat: prevent fswap and fbridge module in Submessages Finschia/wasmd#123

Closed

5 tasks

tkxkd0159 added 5 commits April 26, 2024 17:06

modify proto based on discussion

a48d83f

add codec

6e58a32

lint

897806a

add CHANGELOG

9b34eed

Merge pjdp1

5d8eb42

jaeseung-bae previously approved these changes Apr 26, 2024

View reviewed changes

zemyblue reviewed Apr 29, 2024

View reviewed changes

proto/lbm/fbridge/v1/tx.proto Outdated Show resolved Hide resolved

modify UpdateRole feature

71c5c64

tkxkd0159 dismissed jaeseung-bae’s stale review via 71c5c64 April 29, 2024 02:38

tkxkd0159 requested review from zemyblue and jaeseung-bae April 29, 2024 02:52

zemyblue approved these changes Apr 29, 2024

View reviewed changes

jaeseung-bae approved these changes Apr 29, 2024

View reviewed changes

tkxkd0159 merged commit 82e8936 into pjdp1 Apr 29, 2024
33 checks passed

tkxkd0159 deleted the fbridge-init branch April 29, 2024 04:37

zemyblue mentioned this pull request May 27, 2024

Release finschia-sdk v0.49.0 #1404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: initialize fbridge module #1340

feat: initialize fbridge module #1340

tkxkd0159 commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 24, 2024 •

edited

Loading

170210 left a comment

jaeseung-bae left a comment

feat: initialize fbridge module #1340

feat: initialize fbridge module #1340

Conversation

tkxkd0159 commented Apr 23, 2024 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented Apr 24, 2024 • edited Loading

Codecov Report

170210 left a comment

Choose a reason for hiding this comment

jaeseung-bae left a comment

Choose a reason for hiding this comment

tkxkd0159 commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 24, 2024 •

edited

Loading