fix: update param validation to fail on nil dec #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeseung-bae
requested review from
tkxkd0159,
zemyblue and
0Tech
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
- Coverage 70.39% 70.38% -0.02%
==========================================
Files 643 643
Lines 54779 54793 +14
==========================================
+ Hits 38563 38564 +1
- Misses 14041 14054 +13
Partials 2175 2175
|
jaeseung-bae
added
A: bug
0Tech
previously approved these changes
Mar 28, 2024
|
|
I can't find any in x/distribution, could you share the points? |
Sorry, I made a mistake. There's no problem under x/distribution... |
170210
approved these changes
Mar 28, 2024
zemyblue
approved these changes
Mar 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
* fix: update param validation to fail on nil dec * chore: update changelog (cherry picked from commit 55b6566) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
* fix: update param validation to fail on nil dec (#1323) * fix: update param validation to fail on nil dec * chore: update changelog (cherry picked from commit 55b6566) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: jaeseung-bae <[email protected]> Co-authored-by: Youngtaek Yoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml