feat(wasm): x/wasm stargate migration #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm querier integration tests
Increment x/wasm error codes by 1
Return raw stored bytes for raw queries
Improve query testing
Better calculation of Delegation data
Prevent integer overflow
Test WasmQuery::Raw with missing data
added 4 commits
April 13, 2021 22:22
The tests/, which is the basis of the cli test, has not been ported. And Our modifications, such as encoder of tokens and collections, became unnecessary, so cli tests meaningless.
9 tasks
9 tasks
whylee259
reviewed
Apr 22, 2021
whylee259
reviewed
Apr 22, 2021
Co-authored-by: Yongwoo Lee <[email protected]>
whylee259
approved these changes
Apr 22, 2021
9 tasks
whylee259
changed the title
loloicci
approved these changes
Apr 23, 2021
brew0722
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Cleanup ContractInfo type * Add admin to contract instanciation * Add cli commands for new TX * Add rest support for new TX * Update changelog * Make optional admin flag for better UX * Add flag to not accidentally clear admin on update
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #113
Following the team branch rule, I created pr again after pushing to origin.
#127 (comment)
About the features we customized the cosmwasm
The x/wasm in lbm-sdk/v2 was merged based on 0.12.0-0.1.0(line/cosmwasm and line/wasmvm).
So this merge includes some of our features included in 0.12.0-0.1.0, but there are some features that are excluded.
Contents modified after 0.12.0-0.1.0 will be additionally ported as soon as this PR is completed.
Included:
CustomQuerier&CustomEncoderto use when token/collection migration is complete.
Excluded:
Token/Collection modules has not yet been migrated. so disabled.
tests/used as the base code below has not been migrated.And since the above Token/Collection feature was disabled and couldn't be tested, don't need it now.
Other Modifications when migration
Added
LegacyStoreandLegacyPrefixIteratorline/wasmvmdepends ontendermint/tm-db, and when calling the API, it takes over the store.(
Instantiate,Execute,Query,Migration)However, in
lbm-sdk/v2it usesline/tm-db/v2, there are some fixes, such as removingDomain()chore: bump up tm-db and remove Domain() call #118.It is possible to solve
wasmvmlook atline/tm-db/v2, but I need modifications in the single repository as possible.So, I implemented that class to use Iterator, which reimplemented the Domain receiver method, and used it only in
wasmvm.Changed
Added legacy style path to protobuf script.
x/wasm still uses the old path method (x/wasm/internals/), and various
*.pbfiles are also located here.However, cosmos-sdk 0.42.0 has been implemented to re-located all in
proto/.Can move it self, but considering that it will be fixed in the next cosmwasm update, I responded to the path via W/A.
updated
linkwasmdBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes