Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch a failed proposal tally from proposal.FinalTallyResult in the gprc query #1304

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

170210
Copy link
Contributor

@170210 170210 commented Mar 26, 2024

Description

The TallyResult() is used to fetch the tally result from a proposal, in which the case when a proposal fails does not provide the correct information as this case has been branched into the default case.
This pr cherry-pick the following pr:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 170210
❌ traviolus
You have signed the CLA already but the status is still pending? Let us recheck it.

@170210 170210 marked this pull request as ready for review March 26, 2024 07:12
@170210 170210 requested a review from ulbqb March 26, 2024 07:13
@170210 170210 changed the title fix: fix incorrect query result of Tally for failed proposal fix: fetch a failed proposal tally from proposal.FinalTallyResult in the gprc query Mar 26, 2024
@170210 170210 self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.43%. Comparing base (1038a39) to head (39d1651).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   70.42%   70.43%           
=======================================
  Files         643      643           
  Lines       54730    54730           
=======================================
+ Hits        38546    38547    +1     
+ Misses      14011    14010    -1     
  Partials     2173     2173           
Files Coverage Δ
x/gov/keeper/grpc_query.go 76.38% <100.00%> (ø)

... and 1 file with indirect coverage changes

jaeseung-bae
jaeseung-bae previously approved these changes Mar 26, 2024
tkxkd0159
tkxkd0159 previously approved these changes Mar 26, 2024
@jaeseung-bae jaeseung-bae added A: bug Something isn't working A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users. labels Mar 26, 2024
@170210 170210 dismissed stale reviews from tkxkd0159 and jaeseung-bae via 39d1651 March 27, 2024 01:58
@170210 170210 merged commit e986f03 into Finschia:main Mar 27, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working A: Client Breaking Breaking Protobuf, gRPC and REST routes used by end-users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants