-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update x/collection to use Finschia/cosmos-sdk #1208
Conversation
3a583f9
to
7402333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
e0ffc7b
to
0e7d0a9
Compare
0e7d0a9
to
3e54a0e
Compare
978f66d
to
1fde0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better to apply address codec to this module. It will involve removing usages of AccAddressFromBech32()
and String()
on the addresses.
LGTM (Since this PR was requested by me, I can't click approve by myself) |
Description
closes: #1196
GetSigners()
,Type()
,Route()
,GetSignBytes()
->sdk.Msg
doesn't require those method anymore.x/token
's Class feature/data intox/collection
moduleErrInvalidPermission
( [link, 2] -> [collection, 101] )ErrInvalidContractID
( [contract, 2] -> [collection, 102] )ErrContractNotExist
( [contract, 3] -> [collection, 103] )x/collection
CLITestSuite
verifies CLI processes before broadcasting.E2ETestSuite
for gRPC, TxMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml