Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use CacheContext() in AssertInvariants() #1167

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: use CacheContext() in AssertInvariants() #1167

merged 2 commits into from
Oct 31, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 31, 2023

Description

closes: #865

ref. cosmos/cosmos-sdk#14588

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Oct 31, 2023
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality C:x/crisis labels Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1167 (dfee6a8) into main (e016340) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
- Coverage   69.76%   69.76%   -0.01%     
==========================================
  Files         646      646              
  Lines       67598    67591       -7     
==========================================
- Hits        47163    47157       -6     
+ Misses      18247    18246       -1     
  Partials     2188     2188              
Files Coverage Δ
x/crisis/keeper/keeper.go 82.60% <100.00%> (+0.79%) ⬆️
x/foundation/keeper/internal/invariants.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@tkxkd0159 tkxkd0159 merged commit ca35eab into main Oct 31, 2023
49 checks passed
@tkxkd0159 tkxkd0159 deleted the remove-cctx branch October 31, 2023 09:41
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/crisis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant CacheContext() in x/foundation invariants
3 participants