Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps, crypto): use secp directly instead of wrapper #1163

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 27, 2023

Description

closes: #XXXX

  • Replace btcsuite [secp, ecdsa] with latest decreds library (updating some secp256k1 logics)

ref. cosmos/cosmos-sdk#13513, cosmos/cosmos-sdk#14123, cosmos/cosmos-sdk#15018

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Oct 27, 2023
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality dependencies Pull requests that update a dependency file labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1163 (7a57b21) into main (4f40f5e) will increase coverage by 0.00%.
The diff coverage is 90.19%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         646      646           
  Lines       67593    67598    +5     
=======================================
+ Hits        47159    47163    +4     
- Misses      18246    18247    +1     
  Partials     2188     2188           
Files Coverage Δ
crypto/hd/hdpath.go 98.40% <100.00%> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <100.00%> (ø)
crypto/keys/secp256k1/secp256k1_nocgo.go 78.57% <100.00%> (-4.77%) ⬇️
server/rosetta/converter.go 56.57% <100.00%> (ø)
crypto/ledger/ledger_mock.go 60.00% <87.50%> (+2.18%) ⬆️
crypto/ledger/ledger_secp256k1.go 56.12% <82.60%> (+3.23%) ⬆️

... and 1 file with indirect coverage changes

@tkxkd0159 tkxkd0159 marked this pull request as ready for review October 27, 2023 10:02
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkxkd0159 tkxkd0159 merged commit e016340 into main Oct 31, 2023
37 checks passed
@tkxkd0159 tkxkd0159 deleted the update-btsec branch October 31, 2023 01:28
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
)

* chore(deps, crypto): use secp directly instead of wrapper

* replace it in rosetta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants