Make rdk compatible with tendermint #1115
Merged
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add test about this issue? |
|
@ulbqb |
ulbqb
approved these changes
Sep 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## for-ramus-sdk #1115 +/- ##
================================================
Coverage ? 48.01%
================================================
Files ? 96
Lines ? 9208
Branches ? 0
================================================
Hits ? 4421
Misses ? 4503
Partials ? 284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Currently, finschia-rdk is built on the premise of using BeginRecheckTx, EndRecheckTx, CheckTxAsync defined in ostracon.
#49
#155
Compatibility with tendermint is created by updating checkState at commit time, and rdk can obtain compatibility with both ostracon and tendermint.
One option is to remove compatibility with ostracon and not consider simultaneous execution of CheckTx, but it is an option to keep it as an option when considering simultaneous execution with blockchain core compatible with Ramus or tendermint in the future. I think it's good.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml