chore: increate default valid_sig_block_period (#348)

* chore: increate default valid_sig_block_period * fix: fix test failure * fix: apply comment
Finschia · Oct 14, 2021 · 5d8420a · 5d8420a
1 parent cc78696
commit 5d8420a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/x/auth/ante/ante_test.go b/x/auth/ante/ante_test.go
@@ -160,7 +160,7 @@ func (suite *AnteTestSuite) TestAnteHandlerSigErrors() {
 func (suite *AnteTestSuite) TestAnteHandlerSigBlockHeight() {
 	suite.SetupTest(false) // reset
 
-	suite.ctx = suite.ctx.WithBlockHeight(200) // init block height is 200
+	suite.ctx = suite.ctx.WithBlockHeight(5000) // init block height is 5000
 
 	// Same data for every test cases
 	accounts := suite.CreateTestAccounts(2)
@@ -182,7 +182,7 @@ func (suite *AnteTestSuite) TestAnteHandlerSigBlockHeight() {
 				msg := testdata.NewTestMsg(accounts[0].acc.GetAddress())
 				msgs = []sdk.Msg{msg}
 
-				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv}, []uint64{100}, []uint64{0}
+				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv}, []uint64{3600}, []uint64{0}
 			},
 			false,
 			true,
@@ -200,7 +200,7 @@ func (suite *AnteTestSuite) TestAnteHandlerSigBlockHeight() {
 		{
 			"new tx from correct sig block height",
 			func() {
-				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv}, []uint64{100}, []uint64{1}
+				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv}, []uint64{3600}, []uint64{1}
 			},
 			false,
 			true,
@@ -221,7 +221,7 @@ func (suite *AnteTestSuite) TestAnteHandlerSigBlockHeight() {
 		{
 			"new tx with correct sig block height",
 			func() {
-				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv, accounts[1].priv}, []uint64{100, 101}, []uint64{2, 0}
+				privs, sbh, accSeqs = []cryptotypes.PrivKey{accounts[0].priv, accounts[1].priv}, []uint64{3600, 3601}, []uint64{2, 0}
 			},
 			false,
 			true,

diff --git a/x/auth/types/params.go b/x/auth/types/params.go
@@ -15,7 +15,7 @@ const (
 	DefaultTxSizeCostPerByte      uint64 = 10
 	DefaultSigVerifyCostED25519   uint64 = 590
 	DefaultSigVerifyCostSecp256k1 uint64 = 1000
-	DefaultValidSigBlockPeriod    uint64 = 100
+	DefaultValidSigBlockPeriod    uint64 = 3600 // 1 hour for 1 second block interval
 )
 
 // Parameter keys