Skip to content

Commit

Permalink
docs: fix news version 0.6.4->0.5.4
Browse files Browse the repository at this point in the history
  • Loading branch information
WetRobot committed Jul 1, 2024
1 parent a0818dd commit f90f17e
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 32 deletions.
17 changes: 7 additions & 10 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<!-- generated by R package codedoc; do not modify! -->

## News for version 0.6.4
## News for version 0.5.3

### vame

Fixed an extra comma in a function call when
`ids` was `NULL` and `var_nms` was used to infer the `ids`
(e.g. `vm@var_set_make`).

### vm@var_set_make

Expand All @@ -18,15 +24,6 @@ definition to enable proper checks on inputs when the `maker` is called.
`vm@var_set_maker_set` now ignores arguments passed via `data` to a
`maker` of type `function` that do not correspond to any argument name.


## News for version 0.5.3

### vame

Fixed an extra comma in a function call when
`ids` was `NULL` and `var_nms` was used to infer the `ids`
(e.g. `vm@var_set_make`).

### vm@var_set_value_space_sample

`vm@var_set_value_space_sample` arg `id` now `NULL` by default.
Expand Down
4 changes: 2 additions & 2 deletions R/06_assertions.R
Original file line number Diff line number Diff line change
Expand Up @@ -405,10 +405,10 @@ assert_is_maker <- function(
# required variables. Using `...` is not allowed to enable proper checks
# on inputs when the `maker` is called.
# @codedoc_comment_block specification(var_set_dt$maker)
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.5.3")
# `maker` objects of type `function` can no longer have `...` in their
# definition to enable proper checks on inputs when the `maker` is called.
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.5.3")
dbc::assert(
!"..." %in% names(formals(x)),
x_nm = x_nm,
Expand Down
8 changes: 4 additions & 4 deletions R/09_slot_funs.R
Original file line number Diff line number Diff line change
Expand Up @@ -467,11 +467,11 @@ var_set_make <- function(
deparse1(id), "`. Consider passing `id` explicitly.")
}
arg_list <- handle_arg_data__(data, output_type = "arg_list")
# @codedoc_comment_block news("vm@var_set_make", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_make", "2024-06-19", "0.5.3")
# `vm@var_set_make` passing `var_nms` fixed. It used to pass the
# `var_nm_set` for the corresponding variable set, now it passes arg
# `var_nms` (whether inferred or user-given) as intended.
# @codedoc_comment_block news("vm@var_set_make", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_make", "2024-06-19", "0.5.3")
arg_list[c("var_nms", "dep_var_nm_set")] <- list(
var_nms,
NULL
Expand Down Expand Up @@ -515,10 +515,10 @@ var_set_make <- function(
# corresponding identically named argument in the `maker` function
# definition.
# @codedoc_comment_block vm@var_set_make
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.5.3")
# `vm@var_set_maker_set` now ignores arguments passed via `data` to a
# `maker` of type `function` that do not correspond to any argument name.
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.6.4")
# @codedoc_comment_block news("vm@var_set_maker_set", "2024-06-19", "0.5.3")
maker_fun_arg_nms <- names(formals(maker))
arg_list <- arg_list[intersect(maker_fun_arg_nms, names(arg_list))]
dt <- do.call(maker, arg_list, quote = TRUE)
Expand Down
6 changes: 1 addition & 5 deletions man/VariableMetadata-class.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 8 additions & 11 deletions man/vame.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f90f17e

Please sign in to comment.