Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Clarified that callbacks are FineUploader option. #2014

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

Martinsos
Copy link
Contributor

Thanks for this awesome library!
I have been using it on a project to perform upload to Azure from browser with completely custom UI.

Brief description of the changes

I had hard time figuring out where to define callbacks while reading docs, as it is never explicitly stated that callbacks is a FineUploader option. I ended up trying different things and at the end it worked if I would provide as FineUploader option. Therefore, I thought it would be useful to explicitly state that in docs, and that is what this PR does.

What browsers and operating systems have you tested these changes on?

None, because I did not manage to run building of documentation. I inspected Makefile and tried downloading docfu manually but realized that should probably not be the way to build it and stopped there, because I don't have a good idea how to build it.
Therefore, I am not sure how the PR is going to render. If you could point me toward the way to do this I will, or you can try it out and fix any errors.

Have you written unit tests? If not, explain why.

No, because I changed only documentation.

Copy link
Member

@rnicholus rnicholus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this!

@rnicholus rnicholus merged commit fb09dc4 into FineUploader:master Jun 8, 2018
@Martinsos
Copy link
Contributor Author

Awesome, thanks!
Question for the future, if I change a piece of docs, is there any easy way to render it and check what it looks like?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants