This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Clarified that callbacks are FineUploader option. #2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome library!
I have been using it on a project to perform upload to Azure from browser with completely custom UI.
Brief description of the changes
I had hard time figuring out where to define
callbacks
while reading docs, as it is never explicitly stated thatcallbacks
is a FineUploader option. I ended up trying different things and at the end it worked if I would provide as FineUploader option. Therefore, I thought it would be useful to explicitly state that in docs, and that is what this PR does.What browsers and operating systems have you tested these changes on?
None, because I did not manage to run building of documentation. I inspected Makefile and tried downloading docfu manually but realized that should probably not be the way to build it and stopped there, because I don't have a good idea how to build it.
Therefore, I am not sure how the PR is going to render. If you could point me toward the way to do this I will, or you can try it out and fix any errors.
Have you written unit tests? If not, explain why.
No, because I changed only documentation.