This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Fix reported path when file name also occurs in parent directory name(s) #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Fixes reported path (qqpath) in case when the file name in question appears in one of its parent directory names, see #1976. The original code used indexOf so if the first occurrence was not a file name itself, it stripped way too much from the path.
What browsers and operating systems have you tested these changes on?
Chrome 64.0.3282.167, FF 58.0.2, Edge 41.16299.248.0
Have you written unit tests? If not, explain why.
Unit tests are present, both for normal case where I used the value the current code returns as a reference, and for the case when directory name is the same as the file name.