This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Fix for https://github.com/FineUploader/fine-uploader/issues/1172 #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galvinhsiu
changed the title
rnicholus
suggested changes
Jan 22, 2018
test/unit/chunked-uploads.js
Outdated
| @@ -197,6 +200,86 @@ if (qqtest.canDownloadFileAsBlob) { | |||
| }); | |||
| } | |||
|
|
|||
| function testChunkedEveryFailureAndRecovery(done) { | |||
| assert.expect(6 + (expectedChunks * 17) + (expectedChunks * 6), done); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
client/js/uploader.basic.api.js
Outdated
| _onUploadChunkSuccess: function(id, chunkData) { | ||
| var uploadData = this._uploadData.retrieve({id: id}); | ||
|
|
||
| if (!this._preventRetries[id] && this._options.retry.enableAuto && uploadData.status !== qq.status.PAUSED) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Good feedback, ripped out the unused condition and slightly tweaked the unit test. |
rnicholus
previously approved these changes
Jan 24, 2018
|
Awesome, thanks! I'd like to get this merged in, and maybe you can do that. Let's continue our discussion on Twitter DM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Fix for the long standing issue on uploading using chunking,
this usually kicked in when uploading very large files to S3 (1+
gigabytes). This patch alleviates the need to inflate the autoretry attempt number to be huge number, which may have ramifications on the end user.
The change is on a successful upload chunk, if autoretry is turned on and the upload is not cancelled or paused to reset the autoretry counter to 0 for the given upload handle.
Please refer to:
(#1172).
Recommendations / comments are welcome.
What browsers and operating systems have you tested these changes on?
{example: Safari on iOS 9.1.0 and IE11 on Windows 8.1}
Safari on Mac Sierra
< Firefox 50, > Firefox 50 on Mac Sierra
IE11 on Windows 10 / 8
Edge 14, Edge 15+ on Windows 10
Have you written unit tests? If not, explain why.
Yes, see attached code. Additional test added to fail out each chunk exactly once and then retry successfully, with the check on the attempt number = 1.
fixes #1172