Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Update S3/Azure TypeScript definition file #1830

Merged
merged 1 commit into from
May 13, 2017

Conversation

jleider
Copy link
Contributor

@jleider jleider commented May 2, 2017

This updates the S3 and Azure properties to be optional in the typescript definition file for properties with default values.

@singhjusraj
Copy link
Member

@rnicholus Any idea why Travis build is failing on this one?
Doesn't seem like anything in this PR would break the build.

@rnicholus
Copy link
Member

looks like a temporary Travis issue, somehow the server port was already in use. Restarting the build fixed it.

@singhjusraj
Copy link
Member

@rnicholus Just wanted to know out of 3 merging options, what is your preferred way of merging PR's?
I'll do the same for any future merges.

@rnicholus
Copy link
Member

I'm a fan of squashing all commits into one with a single descriptive commit message.

Unfortunately I haven't fully automated releases yet or setup anyone other than myself to publish to npm, but I'd like to change that...

@singhjusraj singhjusraj merged commit e4da435 into FineUploader:develop May 13, 2017
@singhjusraj
Copy link
Member

@jleider thanks for your contribution.

@rnicholus
Copy link
Member

probably need to cut a new release, push to npm, github releases, etc. @SinghSukhdeep are you interested in becoming more involved in this project? If so, I'd like to give you the power to do all of these things.

@singhjusraj
Copy link
Member

I'll be happy to help as much as I can.
I've never done something like this before, so please let me know the exact steps to follow.

@rnicholus
Copy link
Member

So as much as I'd like to release this, the build is failing due to something Travis-CI "engineers" broke on their end (which tends to happen far too often). So I'm going to have to hold off until both this is fixed and I get another block of time to release a new version. Sorry.

@rnicholus
Copy link
Member

honestly don't know when i'll be able to come back to this, so i was able to work around Travis' latest bug, and released 5.14.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants