Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Add missing return definition #1759

Merged
merged 2 commits into from
Feb 22, 2017
Merged

Conversation

artursvonda
Copy link
Contributor

My env was complaining about implicit any.

Brief description of the changes

Added return type to a typescript method definition.

My env was complaining about implicit any.
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2017

CLA assistant check
All committers have signed the CLA.

@singhjusraj
Copy link
Member

@artursvonda anything else you want to push before I merge this?

@artursvonda
Copy link
Contributor Author

@SinghSukhdeep Nope, ok to merge.

@singhjusraj singhjusraj merged commit 7f7f81b into FineUploader:develop Feb 22, 2017
@rnicholus
Copy link
Member

We can either wait for more changes to pile up, or we can release this as a hotfix: 5.14.1, or as the first beta in 5.15.0 (5.15.0-beta1). Thoughts?

@artursvonda
Copy link
Contributor Author

Currently because of this I can't upgrade to a new current stable as it breaks my build. I'd be happier if this was merged sooner rather than later. :)

@rnicholus
Copy link
Member

rnicholus commented Feb 22, 2017

roger - i'll push out 5.14.1 ASAP

Future reference: I'd like to see PRs squashed w/ a descriptive commit message when merging into develop. Merge commits just clutter up the branch history. The commit history is easier to parse w/ 1 commit per PR.

@rnicholus rnicholus added this to the 5.14.1 milestone Feb 22, 2017
rnicholus added a commit that referenced this pull request Feb 23, 2017
@rnicholus
Copy link
Member

Released in Fine Uploader 15.4.1. Thanks for you work on this @SinghSukhdeep and @artursvonda.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants