feat(uploader*.api.js): addInitialFiles() accepts non-successful files. #1751
Conversation
If status is not provided, defaults to UPLOAD_SUCCESSFUL
docs/features/session.jmd
Outdated
| @@ -66,6 +66,7 @@ Here are the following properties of each `Object` that Fine Uploader recognizes | |||
| * *s3Key: `String` - Key of the file in your S3 bucket. Only required if using Fine Uploader S3. | |||
| * *s3Bucket: `String` - Name of the bucket where the file is stored in S3. Only required if using Fine Uploader S3 and if the bucket cannot be determined by examining the endpoint URL (such as when routing through a CDN). | |||
| * *blobName: `String` - Name of the file in your Azure Blob Storage container. Only required if using Fine Uploader Azure. | |||
| * status: `String` - defaults to `upload successful` | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…q.status.UPLOAD_FAILED`
…nalbion/fine-uploader into feature/initialFiles-with-UPLOAD_FAILED
|
hmmm...
...What if a file has been uploaded but rejected? (like my unit test was uploaded but rejected by Travis CI 😉 ) ...answering my own question: seems that it would only be used for restricting the number of successful uploads |
…` for failed initial uploads
|
Looks good! I still need to do some manual testing. If that is successful, I'll merge into develop. I've marked this and your other recent PR for 5.15.0. I plan to release 5.14.0 in the next few days. |
|
thanks Ray! |
|
Say, you've contributed quite a few high-quality PRs lately. I've been looking for a second maintainer for a while. I've been the only consistent maintainer of this library since 2012, and I could use a second dedicated person. Is this something you're interested in? If so, follow me on Twitter and we can discuss in more detail over DM. |
|
Hi Ray,
Thanks for the offer - I think FineUploader is the first repo I've contributed to which has so many forks that GitHub can't show the graph. Being a maintainer of a project with such a large following would certainly look good on my CV, but I think at the moment I need to focus on what I've already got on my plate.
Nick
On Thursday, 16 February 2017, 16:03, Ray Nicholus <[email protected]> wrote:
Say, you've contributed quite a few PRs lately. I've been looking for a second maintainer for a while. I've been the only consistent maintainer of this library since 2012, and I could use a second dedicated person. Is this something you're interested in? If so, follow me on Twitter and we can discuss in more detail over DM.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Totally understand. If you change your mind, do let me know. When I was tapped to take over Fine Uploader back in 2012, I felt the same way, but it turned out to be a very worthwhile endeavor that opened up a great number of new doors. I wrote about this a bit at https://medium.com/@RayNicholus/disrupting-open-source-the-story-of-fine-uploader-80160eb557d9#.qiez71c3z. |
|
I haven't forgotten about this. I'm in the process of switching jobs, so I have very little time to dedicate to Fine Uploader or other projects during this transition. I hope to get back to a normal OSS contribution schedule in the next couple months. |
|
I hope it's a good move for you |
|
@rnicholus please review merge of #1802 |
Brief description of the changes
If status is not provided, defaults to UPLOAD_SUCCESSFUL
My current project requires that files are scanned for viruses when uploaded, and when the user refreshes the page, the front end should query the back-end and be able to show files which were clean or contain viruses. To do this, I need to call
addInitialFiles()with some havingstatus = qq.status.UPLOAD_FAILEDWhat browsers and operating systems have you tested these changes on?
Chrome (not really applicable)
Are all automated tests passing?
check CI results
Is this pull request against develop or some other non-master branch?
develop