Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Drag Drop Core Module adds style: display: block on hover #1273

Closed
angelsix opened this issue Aug 26, 2014 · 6 comments
Closed

Drag Drop Core Module adds style: display: block on hover #1273

angelsix opened this issue Aug 26, 2014 · 6 comments

Comments

@angelsix
Copy link

When using fu in Core mode and then configuring drop zones, fu adds surplus display: block to my UI elements totally messing up the styling.

The line I comment out to fix the entire issue (and not sure why its even in there) is 7517

qq(dropZone).css({display: "block"});

screen shot 2014-08-26 at 3 10 59 pm

@rnicholus
Copy link
Member

This has been part of the DnD module since the beginning. It is needed to expose initially hidden drop zones when a dragged object enters the page. It exists to serve the default UI, and the standalone DnD module, which is not necessarily used with the Fine Uploader CSS file.

We can investigate ways to more easily override this style without breaking existing standalone DnD workflows.

@angelsix
Copy link
Author

Perhaps a simple check if qq-hide-dropzone isn’t set, don’t do this? It works perfectly fine now I have comment out that line

@rnicholus
Copy link
Member

Yes, perhaps. If the DZ isn't hidden initially, that line is not needed if I recall correctly. In the default case, it is. Apparently, it's uncommon for drop zones to not be block-level elements, yours is the first request we've received to adjust this.

We'll look into this internally and keep this open as a reminder.

@rnicholus rnicholus added this to the 5.1 milestone Sep 24, 2014
rnicholus pushed a commit that referenced this issue Nov 5, 2014
@rnicholus rnicholus added 5 - Done and removed 2 - Do labels Nov 5, 2014
@rnicholus
Copy link
Member

@angelsix I've made this adjustment as part of the 5.1.0 pre-release. If you're interested in verifying before the release, let me know.

@angelsix
Copy link
Author

angelsix commented Nov 7, 2014

Sure, I'm just working on fine uploader stuff today out of coincidence so I can check this out. Do you have a compiled js file for:

jQuery + Azure + DnD + Delete

That is the custom build I used IIRC

@rnicholus
Copy link
Member

We're getting away from these very customized builds due to the associated complexity required to maintain, troubleshoot, and document. Also, it doesn't scale well.

I can send you a jQuery Azure build. Also, since you are using jQuery it seems, please take a peek at #1310.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants