-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Drag Drop Core Module adds style: display: block on hover #1273
Comments
This has been part of the DnD module since the beginning. It is needed to expose initially hidden drop zones when a dragged object enters the page. It exists to serve the default UI, and the standalone DnD module, which is not necessarily used with the Fine Uploader CSS file. We can investigate ways to more easily override this style without breaking existing standalone DnD workflows. |
Perhaps a simple check if qq-hide-dropzone isn’t set, don’t do this? It works perfectly fine now I have comment out that line |
Yes, perhaps. If the DZ isn't hidden initially, that line is not needed if I recall correctly. In the default case, it is. Apparently, it's uncommon for drop zones to not be block-level elements, yours is the first request we've received to adjust this. We'll look into this internally and keep this open as a reminder. |
@angelsix I've made this adjustment as part of the 5.1.0 pre-release. If you're interested in verifying before the release, let me know. |
Sure, I'm just working on fine uploader stuff today out of coincidence so I can check this out. Do you have a compiled js file for: jQuery + Azure + DnD + Delete That is the custom build I used IIRC |
We're getting away from these very customized builds due to the associated complexity required to maintain, troubleshoot, and document. Also, it doesn't scale well. I can send you a jQuery Azure build. Also, since you are using jQuery it seems, please take a peek at #1310. |
When using fu in Core mode and then configuring drop zones, fu adds surplus display: block to my UI elements totally messing up the styling.
The line I comment out to fix the entire issue (and not sure why its even in there) is 7517
qq(dropZone).css({display: "block"});
The text was updated successfully, but these errors were encountered: