Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

3 - Allow a <canvas> to be passed in to the API for upload #1198

Closed
rnicholus opened this issue May 3, 2014 · 3 comments
Closed

3 - Allow a <canvas> to be passed in to the API for upload #1198

rnicholus opened this issue May 3, 2014 · 3 comments
Assignees
@rnicholus
Labels
5 - Done feature
Milestone
5.1.0

Comments

@rnicholus
Copy link
Member

This would essentially add an addCanvases API method. This would essentially turn the <canvas> into a Blob using the code in Scaling module. Since we already have an addBlobs and an addFiles, maybe we should just repurpose addFiles to access Blob or <canvas> or File, or <input type="file"> and deprecate addBlobs.

Inspired by my FedEx Day Project (code/docs still need polish), and this Stack Overflow question.
@rnicholus rnicholus changed the title Allow a <canvas> to be passed in to the API for upload 3 - Allow a <canvas> to be passed in to the API for upload May 6, 2014
@rnicholus rnicholus self-assigned this Jun 4, 2014
rnicholus pushed a commit that referenced this issue Jun 4, 2014
feat($addCanvas): start of ability to accept <canvas> in addFiles m…
eb5b396 
…ethod

- Deprecated addBlobs.
- Removed addBlobs from documentation.
- Redirected unit tests that called addBlobs to use addFiles instead
- addFiles now handles the work of addBlobs and, of course, addFiles
- re-organized addFiles
TODO: accept `<canvas>`

#1198
@rnicholus rnicholus mentioned this issue Jun 25, 2014
Closed
@rnicholus rnicholus mentioned this issue Sep 26, 2014
Closed
2 tasks
rnicholus pushed a commit that referenced this issue Oct 3, 2014
chore(merge): sync with develop branch
b852050 
#1198
rnicholus pushed a commit that referenced this issue Oct 3, 2014
feat(addCanvas): allow addFiles to accept canvas
ee98f62 
TODO:
- canvas to addFiles unit tests
- manual canvas uploading tests

#1198
rnicholus pushed a commit that referenced this issue Oct 6, 2014
docs(addCanvas): add line break to addFiles doc
598b599 
[skip ci]
#1198
rnicholus pushed a commit that referenced this issue Oct 6, 2014
docs(addCanvas): typo
c9f6de6 
[skip ci]
#1198
rnicholus pushed a commit that referenced this issue Oct 6, 2014
test(addCanvas): fix lint error
3266906 
closes #1198
rnicholus pushed a commit that referenced this issue Oct 6, 2014
chore(build): inc build num
6fe8942 
[skip ci]
#1198
@rnicholus
Copy link
Member Author

This feature is now complete in the 5.1.0 pre-release branch (develop).

@cavill
Copy link

cavill commented Jan 2, 2015

Is there any documentation on how to implement this anywhere? (thanks)

@rnicholus
Copy link
Member Author

Yes, we've updated the addFiles API method documentation. http://docs.fineuploader.com/branch/master/api/methods.html#addFiles

@rnicholus rnicholus mentioned this issue Apr 21, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rnicholus rnicholus

Labels
5 - Done feature
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@rnicholus @cavill