Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flash/update make its params optional #51

Closed
wants to merge 22 commits into from
Closed

Conversation

FineArchs
Copy link
Owner

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

github-actions bot commented Feb 19, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -7676,11 +7676,13 @@
                   },
                   "isSuspended": {
                     "type": "boolean"
+                  },
+                  "moderationNote": {
+                    "type": "string"
                   }
                 },
                 "required": [
-                  "host",
-                  "isSuspended"
+                  "host"
                 ]
               }
             }
@@ -61982,11 +61984,7 @@
                   }
                 },
                 "required": [
-                  "flashId",
-                  "title",
-                  "summary",
-                  "script",
-                  "permissions"
+                  "flashId"
                 ]
               }
             }
@@ -77511,6 +77509,12 @@
               "null"
             ],
             "format": "date-time"
+          },
+          "moderationNote": {
+            "type": [
+              "string",
+              "null"
+            ]
           }
         },
         "required": [

Get diff files from Workflow Page

FineArchs and others added 11 commits February 19, 2024 15:49
…ev#13409)

* enhance(frontend): change divider position for MkPostFormAttaches

* docs(changelog): update
* fix(frontend): チャートのラベルが消えている問題を修正

* Update CHANGELOG.md
* fix(frontend): 画面表示後最初の音声再生が爆音になることがある問題を修正

* Update CHANGELOG.md

* Update CHANGELOG.md
* refactor(frontend): 不必要なconsole.logを除去

* Update MkCode.core.vue

* Update game.board.vue
…misskey-dev#13375)

* add unit tests

* cleanup unnecessary type assertions

* `convertedReaction`変数の定義と変換表に対する存在確認処理の整理

* `count`変数の定義とループ処理での`Object.entries()`の活用

* 条件式の整理

* `Array.prototype.reduce`を使うように

* `Array.prototype.reduce`を使うように

* 配列操作を1つのメソッドチェーンに整理

これまでの実装では、`decodeReaction`の返り値が同一になる異なる入力値が同時に複数個存在した場合、後ろのもので上書きされてしまっていたはず。
これからの実装では、後ろのものは前のものに加算される。
(実際にこの挙動の変更が問題になるシチュエーションはまずないはず。)

* add unit test

* ドキュメントコメントの追加と型定義の調整
syuilo and others added 7 commits February 21, 2024 18:35
…消えない問題 (misskey-dev#13349)

* fix: MkUserPopupが表示されてる状態でv-user-previewがついた要素がdetachされるとMkUserPopupが消えない問題

* docs(changelog): previewの中のユーザメンションをホバーした状態で投稿を編集するとユーザの情報popupが消えない問題を修正

* docs(changelog): ユーザの情報のポップアップが消えなくなることがある問題を修正
* refactor: use IdentifiableError instead of NoteCreateService.ContainsProhibitedWordsError

* fix: notes with prohibited words are reprocessed with delay

* docs(changelog): 禁止キーワードを含むノートがDelayed Queueに追加されて再処理される問題

* lint: fix lint errors

* fix: rethrowするべきなのにrethrowし忘れていたのを修正
* refactor: Refactor NoteReadService.read

* clean up

* Update packages/backend/src/core/NoteReadService.ts

---------

Co-authored-by: syuilo <[email protected]>
@FineArchs FineArchs closed this Feb 22, 2024
@FineArchs FineArchs deleted the flash-update branch February 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants