Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.0.5 #21

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Conversation

stainless-bot
Copy link
Collaborator

@stainless-bot stainless-bot commented Oct 2, 2023

Automated Release PR

0.0.5 (2023-10-03)

Full Changelog: v0.0.4...v0.0.5

Features

  • api: add /forward endpoint and other updates (#25) (f16872d)

Bug Fixes

  • prevent index out of range bug during auto-pagination (#23) (24b06e2)

Chores


This Pull Request has been generated automatically as part of Stainless's release process.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request (see details).

More technical details can be found at stainless-api/release-please.

@stainless-bot stainless-bot force-pushed the release-please--branches--main--changes--next branch 2 times, most recently from e086bc7 to 723b3f7 Compare October 3, 2023 04:24
api.md Outdated
@@ -116,6 +124,7 @@ Methods:

Response Types:

- <a href="https://pkg.go.dev/github.com/Finch-API/finch-api-go">finchgo</a>.<a href="https://pkg.go.dev/github.com/Finch-API/finch-api-go#BenefitSupportType">BenefitSupportType</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's scope down changes for this release to only include:

• (new endpoint) /forward
• (new response field) source_id on /employment


So let's exclude this.

api.md Outdated
@@ -139,3 +148,15 @@ Methods:
Custom Methods:

- VerifySignature

# Employer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's exclude this as per 723b3f7#r1344028515

hrisbenefit.go Outdated
@@ -125,6 +125,7 @@ type BenefitFrequency string
const (
BenefitFrequencyOneTime BenefitFrequency = "one_time"
BenefitFrequencyEveryPaycheck BenefitFrequency = "every_paycheck"
BenefitFrequencyMonthly BenefitFrequency = "monthly"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but let's exclude this for now as per 723b3f7#r1344028515

@@ -66,6 +66,9 @@ type EmploymentData struct {
ID string `json:"id"`
// Worker's compensation classification code for this employee
ClassCode string `json:"class_code,nullable"`
// Custom fields for the individual. These are fields which are defined by the
// employer in the system.
CustomFields []EmploymentDataCustomField `json:"custom_fields,nullable"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope down as per 723b3f7#r1344028515

@@ -58,6 +58,8 @@ type Individual struct {
ID string `json:"id"`
Dob string `json:"dob,nullable"`
Emails []IndividualEmail `json:"emails,nullable"`
// The EEOC-defined ethnicity of the individual.
Ethnicity IndividualEthnicity `json:"ethnicity,nullable"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope down as per 723b3f7#r1344028515

api.md Outdated
@@ -1,5 +1,13 @@
# finchgo

Response Types:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this under a dedicated section called Request Forwarding ?

Longer term we may want to restructure some of these methods into a section called Management, but we can do that in the next major version upgrade. For now, let's add Request Forwarding under the Webhooks section.

client.go Outdated
Comment on lines 54 to 57
// The Forward API allows you to make direct requests to an employment system. If
// Finch’s unified API doesn’t have a data model that cleanly fits your needs, then
// Forward allows you to push or pull data models directly against an integration’s
// API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it concise, let's only keep the first sentence here.

@stainless-bot stainless-bot force-pushed the release-please--branches--main--changes--next branch from 4379397 to f16872d Compare October 3, 2023 14:38
api.md Show resolved Hide resolved
provider.go Outdated
Comment on lines 64 to 66
// [DEPRECATED] Whether the Finch integration with this provider uses the Assisted
// Connect Flow by default. This field is now deprecated. Please check for a `type`
// of `assisted` in the `authentication_methods` field instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not include this in the current change set.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump on this @stainless-bot


type RequestForwardingForwardParams struct {
// The HTTP method for the forwarded request. Valid values include: `GET` , `POST`
// , `PUT` , `DELETE` , and `PATCH`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pull the first comma up to the previous line?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stainless-bot stainless-bot force-pushed the release-please--branches--main--changes--next branch from 435d659 to 0dd63e2 Compare October 3, 2023 17:08
@stainless-bot stainless-bot force-pushed the release-please--branches--main--changes--next branch from 96b02f6 to 13f64a3 Compare October 3, 2023 17:50
@stainless-bot stainless-bot force-pushed the release-please--branches--main--changes--next branch from 563c4f0 to 23fa6ec Compare October 3, 2023 17:57
@stainless-bot stainless-bot merged commit b68036c into main Oct 5, 2023
2 checks passed
@stainless-bot
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants