-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.0.5 #21
release: 0.0.5 #21
Conversation
e086bc7
to
723b3f7
Compare
api.md
Outdated
@@ -116,6 +124,7 @@ Methods: | |||
|
|||
Response Types: | |||
|
|||
- <a href="https://pkg.go.dev/github.com/Finch-API/finch-api-go">finchgo</a>.<a href="https://pkg.go.dev/github.com/Finch-API/finch-api-go#BenefitSupportType">BenefitSupportType</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's scope down changes for this release to only include:
• (new endpoint) /forward
• (new response field) source_id on /employment
So let's exclude this.
api.md
Outdated
@@ -139,3 +148,15 @@ Methods: | |||
Custom Methods: | |||
|
|||
- VerifySignature | |||
|
|||
# Employer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's exclude this as per 723b3f7#r1344028515
hrisbenefit.go
Outdated
@@ -125,6 +125,7 @@ type BenefitFrequency string | |||
const ( | |||
BenefitFrequencyOneTime BenefitFrequency = "one_time" | |||
BenefitFrequencyEveryPaycheck BenefitFrequency = "every_paycheck" | |||
BenefitFrequencyMonthly BenefitFrequency = "monthly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but let's exclude this for now as per 723b3f7#r1344028515
hrisemployment.go
Outdated
@@ -66,6 +66,9 @@ type EmploymentData struct { | |||
ID string `json:"id"` | |||
// Worker's compensation classification code for this employee | |||
ClassCode string `json:"class_code,nullable"` | |||
// Custom fields for the individual. These are fields which are defined by the | |||
// employer in the system. | |||
CustomFields []EmploymentDataCustomField `json:"custom_fields,nullable"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope down as per 723b3f7#r1344028515
hrisindividual.go
Outdated
@@ -58,6 +58,8 @@ type Individual struct { | |||
ID string `json:"id"` | |||
Dob string `json:"dob,nullable"` | |||
Emails []IndividualEmail `json:"emails,nullable"` | |||
// The EEOC-defined ethnicity of the individual. | |||
Ethnicity IndividualEthnicity `json:"ethnicity,nullable"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope down as per 723b3f7#r1344028515
api.md
Outdated
@@ -1,5 +1,13 @@ | |||
# finchgo | |||
|
|||
Response Types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this under a dedicated section called Request Forwarding
?
Longer term we may want to restructure some of these methods into a section called Management
, but we can do that in the next major version upgrade. For now, let's add Request Forwarding
under the Webhooks
section.
client.go
Outdated
// The Forward API allows you to make direct requests to an employment system. If | ||
// Finch’s unified API doesn’t have a data model that cleanly fits your needs, then | ||
// Forward allows you to push or pull data models directly against an integration’s | ||
// API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep it concise, let's only keep the first sentence here.
4379397
to
f16872d
Compare
provider.go
Outdated
// [DEPRECATED] Whether the Finch integration with this provider uses the Assisted | ||
// Connect Flow by default. This field is now deprecated. Please check for a `type` | ||
// of `assisted` in the `authentication_methods` field instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not include this in the current change set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump on this @stainless-bot
requestforwarding.go
Outdated
|
||
type RequestForwardingForwardParams struct { | ||
// The HTTP method for the forwarded request. Valid values include: `GET` , `POST` | ||
// , `PUT` , `DELETE` , and `PATCH`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pull the first comma up to the previous line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump @stainless-bot
435d659
to
0dd63e2
Compare
96b02f6
to
13f64a3
Compare
563c4f0
to
23fa6ec
Compare
🤖 Release is at https://github.com/Finch-API/finch-api-go/releases/tag/v0.0.5 🌻 |
Automated Release PR
0.0.5 (2023-10-03)
Full Changelog: v0.0.4...v0.0.5
Features
/forward
endpoint and other updates (#25) (f16872d)Bug Fixes
Chores
This Pull Request has been generated automatically as part of Stainless's release process.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request (see details).
More technical details can be found at stainless-api/release-please.