Skip to content
This repository has been archived by the owner on Jun 9, 2020. It is now read-only.

Update dependency supertest to v3.4.1 #82

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 16, 2019

This PR contains the following updates:

Package Type Update Change References
supertest devDependencies minor 3.3.0 -> 3.4.1 source

Release Notes

visionmedia/supertest

v3.4.1

Compare Source

===================

v3.4.0

Compare Source

===================

  • PR-532 - Packages updated, pipeline more explicit, documentation updated (thanks @​rimiti)
  • PR-517 - Documentation updated (thanks @​oprogramador)
  • PR-513 - Use more robust Array instance check (thanks @​rubendg)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from a team January 16, 2019 08:41
@sjparkinson sjparkinson added bug Something isn't working. dependencies labels Jan 16, 2019
@sjparkinson
Copy link
Contributor

Looks like this includes a major version bump of superagent.

ladjs/supertest@v3.3.0...v3.4.0#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L13

I'd guess there's something we need to change about our test to get this one passing.

There isn't much to go off on the superagent readme, https://github.com/visionmedia/superagent#upgrading-from-previous-versions.

Oh, and an issue tracking the problem ladjs/supertest#534 🎉

@sjparkinson
Copy link
Contributor

And these are the affected tests, which still look valid.

tako/test/routes.test.js

Lines 43 to 53 in caaf05d

test("reject unauthorised request when a bearer token is loaded", async () => {
await request(server)
.get("/tako/repositories")
.set("Accept", "application/json")
.expect(401);
await request(server)
.get("/tako/repositories?topic=express")
.set("Accept", "application/json")
.expect(401);
});

@renovate renovate bot changed the title Update dependency supertest to v3.4.0 Update dependency supertest to v3.4.1 Jan 16, 2019
@sjparkinson sjparkinson merged commit a1d6aac into master Jan 21, 2019
@sjparkinson sjparkinson deleted the renovate/supertest-3.x branch January 21, 2019 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants