chore: testing this out without node sass #1920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
reviewed
Jan 10, 2025
package.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/Financial-Times/origami#readme", | |||
| "volta": { | |||
| "node": "22.2.0", | |||
There was a problem hiding this comment.
This will break the website relies on Object.groupBy, are you able to put this back to a later version of node?
There was a problem hiding this comment.
Definitely can be reverted 😄 I forgot about that part as it was included in the rabbit hole trying to fix things.
j-mes
requested review from
ft-dependency-auto-merger and
a team
as code owners
notlee
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sassfor my own sanity 😆Describe your changes
Currently the mono-repo needs
node-sasswhich is deprecated, for tests. This particular dependency requires you to have python installed on the machine to do… JavaScript things.Issue ticket number and link
N/A - adhoc
Link to Figma designs
N/A
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md