-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align text input #1918
Merged
Merged
feat: align text input #1918
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fdd89e8
feat: align o-forms text-input to new designs
frshwtr 310ff1e
chore: Merge branch '2025-release' into 2025-release-align-text-input
frshwtr 0bf1d98
chore: use --o3-border-radius token in form text inputs
frshwtr 8de6520
chore: update form font size and borders
frshwtr 7cb74de
chore: align form border width
frshwtr 93ad4b5
chore: enable border-radius on professional
frshwtr 5b3c03a
chore: reduce border to match design
frshwtr 5fff75e
chore: update form typography
frshwtr badbc57
feat: align o2 forms to designs
frshwtr c6b6540
chore: Merge branch '2025-release' into 2025-release-align-text-input
frshwtr 85a1c3a
chore: restore border-radius to source, add exception for border radi…
frshwtr 31351a3
chore: add lineheight to input fields
frshwtr 65364f2
Merge branch '2025-release' into 2025-release-align-text-input
frshwtr 4f6951c
chore: add correct padding to inputs
frshwtr cd122b7
chore: ensure o3-form text input is 44px
frshwtr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -339,4 +339,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,13 +2,15 @@ | |
/// @param {Boolean} $disabled Whether to output disabled state styling | ||
/// @output base styles for select, textarea and text input | ||
@mixin _oFormsInputBase($disabled) { | ||
font-family: inherit; | ||
font-size: inherit; | ||
font-family: oPrivateFoundationGet('o3-font-family-metric'); | ||
font-size: oPrivateFoundationGet('o3-font-size-metric2-1'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Getting ahead on OR-1195 here! The vertical alignment looks a touch low, but setting the |
||
line-height: oPrivateFoundationGet('o3-font-lineheight-metric2-1'); | ||
background-color: _oFormsGet('default-background'); | ||
border: $_o-forms-border; | ||
border-radius: oPrivateFoundationGet('o3-border-radius-1'); | ||
box-sizing: border-box; | ||
min-height: $_o-forms-spacing-ten; | ||
padding: $_o-forms-spacing-two; | ||
min-height: $_o-forms-spacing-eleven; | ||
padding: oPrivateFoundationGet('o3-spacing-4xs') oPrivateFoundationGet('o3-spacing-2xs'); | ||
width: 100%; | ||
|
||
@if $disabled { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for going half a pixel there? Mostly for my own curiosity!
I also can see this in the design file as well. Also curious to as why 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure, Deyan may have an answer.