CPP-733 Jest plugin #160
Merged
CPP-733 Jest plugin #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivomurrell
approved these changes
Jan 14, 2022
core/sandbox/package.json
Outdated
| @@ -34,7 +34,10 @@ | |||
| "@dotcom-tool-kit/node": "file:../../plugins/node" | |||
| }, | |||
| "husky": { | |||
| "pre-commit": "dotcom-tool-kit git:precommit" | |||
| "pre-commit": "dotcom-tool-kit git:precommit", | |||
There was a problem hiding this comment.
suggestion: this line can now be safely deleted after #157
Suggested change
| "pre-commit": "dotcom-tool-kit git:precommit", |
plugins/jest/package.json
Outdated
| "license": "ISC", | ||
| "dependencies": { | ||
| "@dotcom-tool-kit/types": "file:../../lib/types", | ||
| "jest-cli": "^27.4.7" |
There was a problem hiding this comment.
question: would it be better to have jest-cli as a peer dependency so that the consumer can use their own copy? we aren't consistent with this at the moment
There was a problem hiding this comment.
great suggestion 👍
plugins/jest/src/run-jest.ts
Outdated
| if (code === 0) { | ||
| resolve() | ||
| } else { | ||
| reject(new Error(`Jest returned an error`)) |
There was a problem hiding this comment.
nitpick: we should only throw ToolKitError from our code
Suggested change
| reject(new Error(`Jest returned an error`)) | |
| reject(new ToolKitError(`Jest returned an error`)) |
plugins/jest/src/run-jest.ts
Outdated
|
|
||
| const jestCLIPath = require.resolve('jest-cli/bin/jest') | ||
|
|
||
| export default function runJest(mode: string, options: JestOptions) : Promise<void> { |
There was a problem hiding this comment.
nitpick: we should limit the mode type to the two possible string literals it is allowed to be
Suggested change
| export default function runJest(mode: string, options: JestOptions) : Promise<void> { | |
| type JestMode = "ci" | "local" | |
| export default function runJest(mode: JestMode, options: JestOptions) : Promise<void> { |
| @@ -17,7 +17,7 @@ console.log('📦 initialising package') | |||
| execSync('npm init -y --scope @dotcom-tool-kit') | |||
|
|
|||
| console.log('📥 installing dependencies') | |||
| execSync('npm install ../task') | |||
| execSync('npm install ../../lib/types') | |||
|
|
||
| jest.mock('child_process', () => ({ | ||
| fork: jest.fn(() => { | ||
| // return a fake emitter that immediately sends an "exit" event, so the webpack task resolves |
There was a problem hiding this comment.
nitpick: copy and paste error 😄
Suggested change
| // return a fake emitter that immediately sends an "exit" event, so the webpack task resolves | |
| // return a fake emitter that immediately sends an "exit" event, so the jest task resolves |
ivomurrell
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no well documented way run jest programmatically (issue) so I have used the cli to run jest