Merge pull request #1021 from Financial-Times/node-20

feat: support Node.js 20
Financial-Times · Jan 17, 2024 · b33c591 · b33c591
2 parents 9e387a2 + 2adefcd
commit b33c591
Show file tree

Hide file tree

Showing 27 changed files with 112 additions and 101 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -6,9 +6,12 @@ orbs:
 executors:
   node:
     docker:
-      - image: cimg/node:18.16-browsers
+      - image: cimg/node:20.11-browsers
         environment:
           NODE_OPTIONS: "--openssl-legacy-provider"
+  node18_19:
+    docker:
+      - image: cimg/node:18.19-browsers
   node16_20:
     docker:
       - image: cimg/node:16.20-browsers
@@ -182,6 +185,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - test:
           requires:
@@ -191,6 +195,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - deploy:
           filters:
@@ -212,6 +217,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - test:
           requires:
@@ -221,6 +227,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
 
   build-test-publish:
@@ -233,6 +240,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - test:
           filters:
@@ -244,6 +252,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - publish:
           context: npm-publish-token
@@ -262,6 +271,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - test:
           filters:
@@ -273,6 +283,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - prepublish:
           context: npm-publish-token

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -85,8 +85,8 @@
     "typescript": "4.1.6"
   },
   "engines": {
-    "node": "16.x || 18.x",
-    "npm": "7.x || 8.x || 9.x"
+    "node": "16.x || 18.x || 20.x",
+    "npm": "7.x || 8.x || 9.x || 10.x"
   },
   "husky": {
     "hooks": {

diff --git a/packages/dotcom-build-base/package.json b/packages/dotcom-build-base/package.json
@@ -30,8 +30,8 @@
     "webpack": "^4.39.2"
   },
   "engines": {
-    "node": "16.x || 18.x",
-    "npm": "7.x || 8.x || 9.x"
+    "node": "16.x || 18.x || 20.x",
+    "npm": "7.x || 8.x || 9.x || 10.x"
   },
   "files": ["dist/", "src/"],
   "repository": {

diff --git a/packages/dotcom-build-code-splitting/package.json b/packages/dotcom-build-code-splitting/package.json
@@ -41,8 +41,8 @@
     "check-engine": "^1.10.1"
   },
   "engines": {
-    "node": "16.x || 18.x",
-    "npm": "7.x || 8.x || 9.x"
+    "node": "16.x || 18.x || 20.x",
+    "npm": "7.x || 8.x || 9.x || 10.x"
   },
   "files": ["dist/", "src/"],
   "repository": {

diff --git a/packages/dotcom-build-images/package.json b/packages/dotcom-build-images/package.json
@@ -29,8 +29,8 @@
     "check-engine": "^1.10.1"
   },
   "engines": {
-    "node": "16.x || 18.x",
-    "npm": "7.x || 8.x || 9.x"
+    "node": "16.x || 18.x || 20.x",
+    "npm": "7.x || 8.x || 9.x || 10.x"
   },
   "files": ["dist/", "src/"],
   "repository": {