670 actions deprecation #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version of github actions used in Actions pipelines. Both actions/checkout@v3 and actions/[email protected] need to be updated to v4. Testing on forked repo it appears this is safe for us to perform. Signed-off-by: Mike Fuller <[email protected]>
shawnalpay
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
@mike-finopsorg Does the minor version matter? You've updated to version 4, but the most recent version of actions/checkout is 4.2.2 -- so do we perhaps want to upgrade all the way and use actions/[email protected]?
I'll leave that to you to decide, as it works fine as-is. Approving.
shawnalpay
added
the
repo maintenance
gparker-at-sf
approved these changes
Dec 19, 2024
ljadvey
approved these changes
Dec 19, 2024
Yeah good point. I went ahead and tested the latest point release of both actions and updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version of github actions used in Actions pipelines. Both actions/checkout@v3 and actions/[email protected] need to be updated to v4. Testing on forked repo it appears this is safe for us to perform.