-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commitment Flexibility Appendix #535
Open
cnharris10
wants to merge
25
commits into
working_draft
Choose a base branch
from
size-flexibility-appendix
base: working_draft
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d751750
Initial draft
cnharris10 943efd7
Update commitment_discounts.md
cnharris10 f21c015
Incorporated a few suggestions from Shawn Alpay
cnharris10 e864bb5
Ignore MD031: Fenced code blocks should be surrounded by blank lines …
cnharris10 3fec018
Grammar fixes, calling out when Consumed{Quantity,Unit} are null, and…
cnharris10 788c90c
Update specification/appendix/commitment_discounts.md
cnharris10 93199b7
Specify that 1 resource is being modeled
cnharris10 f43ee82
Size flexibility Appendix
cnharris10 e4bd744
Update commitment_discounts.md
cnharris10 167f67a
Fix DateTime format
cnharris10 d50cbbd
Merge branch 'commitment-discount-appendix' of github.com:FinOps-Open…
cnharris10 8af4400
Fix DateTime format
cnharris10 4b2ebb0
Adding editorial changes from Michael
cnharris10 e7eff95
Merge branch 'commitment-discount-appendix' into size-flexibility-app…
cnharris10 a0d27bc
Small term/wording updates based on the evolution of pr: https://gith…
cnharris10 8b4d8bb
Merge branch 'commitment-discount-appendix' into size-flexibility-app…
cnharris10 10d065c
Small term/wording updates based on the evolution of pr: https://gith…
cnharris10 821d926
Rearrange property in JSON block
cnharris10 4e57192
Minor fixes
cnharris10 d5ab0a9
Merge branch 'commitment-discount-appendix' into size-flexibility-app…
cnharris10 7be3840
Adding 'Commitment Discount Visibility' to v1.1 Release Planning
cnharris10 6c9b254
Merge branch 'working_draft' of github.com:FinOps-Open-Cost-and-Usage…
cnharris10 86f0149
Merge branch 'working_draft' into size-flexibility-appendix
cnharris10 9fc11ab
Rebasing against working_draft
cnharris10 74fe05d
Bug fix: '{Billing,Charge}Period{Start,End}Date' should be '{Billing,…
cnharris10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph was added to highlight the importance of using different units for commitment discounts with/without commitment flexibility