-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOCUS #317: BillingAccountType and SubAccountType #287
base: working_draft
Are you sure you want to change the base?
Conversation
7be8d6f
to
248eaa8
Compare
Can you share some examples of "labels"? Thanks! |
Examples are in the supporting content: https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/pull/287/files#diff-1a657454b35fbf6f129f8110ebe3a78a1514483cac3fe86b7a772d38edaaafef |
It's probably advisable to provide provider-specific labels for the columns in the metadata rather than in additional columns. |
The next obvious column addition after this is something like "ParentAccount{ID,Name}" or "GroupingAccount{ID,Name}" to denote:
I'll add this issue/proposal and link to this as well. |
BillingAccountType can change across billing accounts from the same provider. If we put it in metadata, then we won't have it available to explain datasets aggregated across providers. |
See the supporting content: https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/pull/287/files#diff-4660da431689f69fb2f3e849c945ba9aac12542a8d2156c0f3b71513554344a3 For SubAccount for instance, examples are "Member Account", "Project", and "Subscription". |
I think this should be reviewed and discussed, not to be included in v1.0 GA without alignment |
This is being discussed as a possible metadata column that can later be added explicitly by providers to the dataset OR post-processed by consumers if they find this valuable. Leaving the PR open in case there's traction for still adding as a column but the maintainer group was leaning towards adding as a metadata field first. |
Discussion Topics:
I vote for including them as mandatory columns. |
@ijurica - From an OCI perspective we intend to map SubAccountType to tenant id. This will contain either parent or child tenancy id depending on where usage was incurred. |
Presented on April 18th meeting:
|
Realizing this is just my viewpoint as a new joiner to the project: |
Are there any specific use cases these columns would help? I'm concerned whether the value of these columns are worth increasing the schema size. |
790156d
to
609fb6d
Compare
I don't know if I understand the value of these fields to a practitioner |
Suggesting adding BillingAccountType and SubAccountType to include the provider-specific labels for the BillingAccountId/Name and SubAccountId/Name. This is similar to ResourceType and CommitmentDiscountType for their respective ID and Name columns.