Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOCUS #317: BillingAccountType and SubAccountType #287

Open
wants to merge 2 commits into
base: working_draft
Choose a base branch
from

Conversation

flanakin
Copy link
Contributor

Suggesting adding BillingAccountType and SubAccountType to include the provider-specific labels for the BillingAccountId/Name and SubAccountId/Name. This is similar to ResourceType and CommitmentDiscountType for their respective ID and Name columns.

@rupagcp
Copy link
Contributor

rupagcp commented Jan 29, 2024

Can you share some examples of "labels"? Thanks!

@flanakin
Copy link
Contributor Author

Can you share some examples of "labels"? Thanks!

Examples are in the supporting content: https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/pull/287/files#diff-1a657454b35fbf6f129f8110ebe3a78a1514483cac3fe86b7a772d38edaaafef

@TDubovchenko
Copy link
Contributor

It's probably advisable to provide provider-specific labels for the columns in the metadata rather than in additional columns.

@cnharris10
Copy link
Contributor

The next obvious column addition after this is something like "ParentAccount{ID,Name}" or "GroupingAccount{ID,Name}" to denote:

AWS --> Organizational Units
Azure --> Management Groups and/or Resource Groups?
GCP --> Folders

I'll add this issue/proposal and link to this as well.

@flanakin
Copy link
Contributor Author

flanakin commented Mar 7, 2024

It's probably advisable to provide provider-specific labels for the columns in the metadata rather than in additional columns.

BillingAccountType can change across billing accounts from the same provider.
SubAccountType can change across providers.

If we put it in metadata, then we won't have it available to explain datasets aggregated across providers.

@flanakin
Copy link
Contributor Author

flanakin commented Mar 7, 2024

Can you share some examples of "labels"? Thanks!

See the supporting content: https://github.com/FinOps-Open-Cost-and-Usage-Spec/FOCUS_Spec/pull/287/files#diff-4660da431689f69fb2f3e849c945ba9aac12542a8d2156c0f3b71513554344a3

For SubAccount for instance, examples are "Member Account", "Project", and "Subscription".

@rupagcp
Copy link
Contributor

rupagcp commented Mar 7, 2024

I think this should be reviewed and discussed, not to be included in v1.0 GA without alignment

@udam-f2
Copy link
Contributor

udam-f2 commented Mar 12, 2024

This is being discussed as a possible metadata column that can later be added explicitly by providers to the dataset OR post-processed by consumers if they find this valuable. Leaving the PR open in case there's traction for still adding as a column but the maintainer group was leaning towards adding as a metadata field first.

@jpradocueva jpradocueva added this to the v1.0 milestone Mar 18, 2024
@flanakin flanakin changed the title BillingAccountType and SubAccountType FOCUS #317: BillingAccountType and SubAccountType Apr 16, 2024
@ijurica
Copy link
Contributor

ijurica commented Apr 17, 2024

Discussion Topics:

  • Do practitioners find this information relevant?

    • Do we require clear, out-of-the-box understanding of what information is provided in SubAccountId and BillingAccountId?
  • Should these be provided as columns or in metadata?

    • it's important to determine if all providers will consistently provide the same values in all charge records. For example, in case of Oracle, this might not apply to the SubAccountType, i.e. we might expect one of two values depending on a charge Tenancy or Child-Tenancy. (@arrarama Is this assumption correct?)
    • Even if the same values are provided in all charge records the question is whether practitioners prefer ease of access or reduced data size.
  • If provided as columns, what feature level should we require?

    • Considering that BillingAccountId and SubAccountId are already mandatory, providers should be able to provide this additional information as well. Therefore, the decision hinges on practitioners: Assuming practitioners find this info valuable for inclusion do they require consistency across all billing data sets from various providers?

I vote for including them as mandatory columns.

@arrarama
Copy link
Contributor

@ijurica - From an OCI perspective we intend to map SubAccountType to tenant id. This will contain either parent or child tenancy id depending on where usage was incurred.

@jpradocueva
Copy link
Contributor

Presented on April 18th meeting:
Important feedback:

  • Some members don't consider these columns critical for v1.0
  • It would be good to have the support from other cloud service providers

@mlohmeijer
Copy link

Presented on April 18th meeting: Important feedback:

  • Some members don't consider these columns critical for v1.0
  • It would be good to have the support from other cloud service providers

Realizing this is just my viewpoint as a new joiner to the project:
Having followed the discussion in this meeting: as a practitioner the ID's are more important than having the Type attached to the ID if the Type is only a different name as a result of the type of contract (in the given Microsoft example). I don't see the Type as a field that would get actively used in cost/billing analyses or showback/chargeback scenarios.

@AWS-ZachErdman
Copy link
Contributor

AWS-ZachErdman commented Apr 25, 2024

Are there any specific use cases these columns would help? I'm concerned whether the value of these columns are worth increasing the schema size.

@jpradocueva jpradocueva modified the milestones: v1.0, v1.1 Apr 25, 2024
@jpradocueva jpradocueva added the P2 label May 24, 2024
@flanakin flanakin force-pushed the flanakin/accounttype branch from 790156d to 609fb6d Compare June 8, 2024 07:07
@rupagcp
Copy link
Contributor

rupagcp commented Jun 8, 2024

I don't know if I understand the value of these fields to a practitioner

@shawnalpay shawnalpay added the 1.2 consideration To be considered for release 1.2 label Oct 30, 2024
@shawnalpay shawnalpay modified the milestones: v1.1, v1.2 Nov 25, 2024
@shawnalpay shawnalpay added 1.2 Agreed scope for release 1.2 and removed 1.2 consideration To be considered for release 1.2 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2 Agreed scope for release 1.2 dimensionality Fields that describe / group / filter metrics
Projects
Status: Parking Lot
Development

Successfully merging this pull request may close these issues.

[Work_Item] Denote provider entities represented in Billing Account and Sub Account