Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags dimension #227

Merged
merged 39 commits into from
Nov 7, 2023
Merged

Add Tags dimension #227

merged 39 commits into from
Nov 7, 2023

Conversation

cnharris10
Copy link
Contributor

@cnharris10 cnharris10 commented Oct 18, 2023

Closes #226
Doc

Preview (updated 10/31/23)

image image

@cnharris10 cnharris10 requested a review from a team as a code owner October 18, 2023 20:03
@cnharris10 cnharris10 requested a review from mattray October 21, 2023 00:44
Copy link
Contributor

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
supporting_content/dimensions/tags.md Outdated Show resolved Hide resolved
@cnharris10 cnharris10 requested a review from ljadvey November 6, 2023 21:42
Copy link
Contributor

@udam-f2 udam-f2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
specification/dimensions/tags.md Outdated Show resolved Hide resolved
@joshk0
Copy link
Contributor

joshk0 commented Nov 7, 2023

Since we're going this direction I will do a follow up change to tweak, but happy for this to go in right now.

Copy link
Contributor

@shawnalpay shawnalpay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put you to bed, grandpa.

@cnharris10 cnharris10 dismissed stale reviews from ljadvey and TDubovchenko November 7, 2023 19:22

Incorporated

@cnharris10 cnharris10 merged commit baaca26 into working_draft Nov 7, 2023
1 check passed
@udam-f2 udam-f2 deleted the 226-tags-dimension branch November 13, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Tags dimension
10 participants