Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only allow unlocked content types to be added to a collection #77

Merged
merged 7 commits into from
Oct 5, 2022
Merged

fix: Only allow unlocked content types to be added to a collection #77

merged 7 commits into from
Oct 5, 2022

Conversation

Bernardvdv
Copy link
Contributor

Adding a draft object to a page owned by another user should be allowed unless version locked

@Bernardvdv Bernardvdv marked this pull request as draft October 3, 2022 10:24
@Bernardvdv Bernardvdv marked this pull request as ready for review October 3, 2022 15:02
@Bernardvdv Bernardvdv changed the title fix: Allowing children added unless locked fix: Only allow unlocked content types to be added to a collection Oct 3, 2022
michaeljcollinsuk
michaeljcollinsuk suggested changes Oct 4, 2022
View reviewed changes
tests/test_models_monkeypatch.py Show resolved Hide resolved
tests/test_models_monkeypatch.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
adam-murray
adam-murray approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@adam-murray adam-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! It's a shame moderation has its utils within the outer directory, so that factories had to be replicated, but not worth the update to moderation!

@Bernardvdv Bernardvdv merged commit 753eb80 into FidelityInternational:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

@adam-murray adam-murray adam-murray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bernardvdv @adam-murray @michaeljcollinsuk