Enable configurable silent email failures

djangocms_version_locking/conf.py

@@ -0,0 +1,6 @@
+from django.conf import settings
+
+
+EMAIL_NOTIFICATIONS_FAIL_SILENTLY = getattr(
+    settings, "EMAIL_NOTIFICATIONS_FAIL_SILENTLY", False
+)

djangocms_version_locking/helpers.py

@@ -9,6 +9,7 @@
 from djangocms_versioning.models import Version
 
 from .admin import VersionLockAdminMixin
+from .conf import EMAIL_NOTIFICATIONS_FAIL_SILENTLY
 from .models import VersionLock
 
 
@@ -147,7 +148,9 @@ def send_email(
         from_email=settings.DEFAULT_FROM_EMAIL,
         to=recipients,
     )
-    return message.send()
+    return message.send(
+        fail_silently=EMAIL_NOTIFICATIONS_FAIL_SILENTLY
+    )
 
 
 def get_latest_draft_version(version):

djangocms_version_locking/test_utils/factories.py

@@ -2,13 +2,14 @@
 from django.contrib.contenttypes.models import ContentType
 
 import factory
+from factory.django import DjangoModelFactory
 from factory.fuzzy import FuzzyChoice, FuzzyText
 
 from ..models import Version
 from .polls.models import Answer, Poll, PollContent
 
 
-class UserFactory(factory.django.DjangoModelFactory):
+class UserFactory(DjangoModelFactory):
     username = FuzzyText(length=12)
     first_name = factory.Faker('first_name')
     last_name = factory.Faker('last_name')
@@ -19,7 +20,7 @@ class Meta:
         model = User
 
 
-class AbstractVersionFactory(factory.DjangoModelFactory):
+class AbstractVersionFactory(DjangoModelFactory):
     object_id = factory.SelfAttribute('content.id')
     content_type = factory.LazyAttribute(
         lambda o: ContentType.objects.get_for_model(o.content))
@@ -30,14 +31,14 @@ class Meta:
         abstract = True
 
 
-class PollFactory(factory.django.DjangoModelFactory):
+class PollFactory(DjangoModelFactory):
     name = FuzzyText(length=6)
 
     class Meta:
         model = Poll
 
 
-class PollContentFactory(factory.django.DjangoModelFactory):
+class PollContentFactory(DjangoModelFactory):
     poll = factory.SubFactory(PollFactory)
     language = FuzzyChoice(['en', 'fr', 'it'])
     text = FuzzyText(length=24)
@@ -65,7 +66,7 @@ def version(self, create, extracted, **kwargs):
         PollVersionFactory(content=self, **kwargs)
 
 
-class AnswerFactory(factory.django.DjangoModelFactory):
+class AnswerFactory(DjangoModelFactory):
     poll_content = factory.SubFactory(PollContentFactory)
     text = factory.LazyAttributeSequence(
         lambda o, n: 'Poll %s - Answer %d' % (o.poll_content.poll.name, n))

docs/notifications.md

@@ -0,0 +1,7 @@
+Notifications
+==========================
+
+
+Email notifications
+------------------------
+Configure email notifications to fail silently by setting: ``EMAIL_NOTIFICATIONS_FAIL_SILENTLY=True``

tests/requirements.txt

@@ -6,3 +6,8 @@ isort
 mock
 djangocms_helper
 factory-boy
+django-classy-tags<2.0.0  # Support Django<2.0
+django-sekizai<2.0.0  # Support Django<2.0
+
+# Get the latest cms v4 compatible djangocms-text-ckeditor
+https://github.com/divio/djangocms-text-ckeditor/tarball/support/4.0.x#egg=djangocms-text-ckeditor