Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Circle CI integration #60

Merged
merged 12 commits into from
Feb 20, 2020
Merged

Add Circle CI integration #60

merged 12 commits into from
Feb 20, 2020

Conversation

Aiky30
Copy link
Member

@Aiky30 Aiky30 commented Feb 19, 2020

Adding the Circle CI integration has shown that the code base contains test errors. This change should be merged to ensure that we do not introduce any more errors.

Copy link
Contributor

@jonathan-s jonathan-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the tests are failing since before. We want this PR merged in so that it is visible that tests are failing. This PR also shows that the tests were failing prior to any upgrade of django 2.2

@Aiky30 Aiky30 merged commit 773e895 into master Feb 20, 2020
Aiky30 added a commit that referenced this pull request Nov 19, 2021
…or fully override (#60)

* Carried over work previously done to make the application code reusable

* Working example of a private addon for the navigation that reuses the open source package

* Fixed failing tests
@Aiky30 Aiky30 deleted the feature/add-ci-integration branch January 18, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants