Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #45

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Update README.rst #45

merged 3 commits into from
Sep 3, 2019

Conversation

geoidesic
Copy link
Contributor

Updated for RST

Updated for RST
Tidied markup
README.rst Outdated
Version-locking makes use of the django-cms 4.x App Registration mechanism to allow models from other addon's (i.e. content-types) to be registered for use with version-locking.
`®`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

®?

README.rst Show resolved Hide resolved
README.rst Outdated

- The primary change is that it locks a version to its author when a draft is created.
- That version becomes automatically unlocked again once it is published.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how a published version could be locked? I mean AFAIK a published version cannot be edited even without locking (if a draft version doesn't exist the edit button actually creates a new version).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. Draft versions are locked. If we didn't remove the lock when publishing, then it would stay locked.

README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
Clarifications
@Aiky30 Aiky30 merged commit 8b03e0c into master Sep 3, 2019
Aiky30 added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants