feature removed unpublished pages from menu item admin select view fo… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced characters in line
corrected released versions
- Pin django-cms to version 4.0.0 - Pin djangocms-alias to version 1.11.0 - Pin djangocms-versioning to version 1.2.2 All of the above where required as they previously followed latest releases for which djangocms-navigation was incompatible with.
It seems like page.get_title_obj().versions.first() can be of type NoneType which is something that we need to take into account when trying to access its state attribute.
joshyu
reviewed
Feb 16, 2024
pinned djangocms-references
reverting back
updated references to 1.4.3
joshyu
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unpublished pages from menu item select view admin