Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to use array of commands as runJavaParameters #93

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

lightsuner
Copy link
Contributor

@lightsuner lightsuner commented Dec 6, 2017

Hi @FibreFoX. It seems that command.add(runJavaParameter); not properly works with multiple parameters (related to issue #77).

This PR adds new variable runJavaParameters to avoid breaking changes. runJavaParameters works with array of params.

Example:

jfx {
    verbose = true
    mainClass = 'com.test.javafx.App'
    vendor = 'YourName'
    appName = 'SimpleAppName'
    runJavaParameters = ["-Xdebug", "-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005"]
}

@FibreFoX
Copy link
Owner

FibreFoX commented Dec 7, 2017

This sounds very reasonable, and might be some reason for #77. As I'm a bit over-loaded with paid-work-stuff, I'll check when having more time.

@FibreFoX FibreFoX merged commit 5b90599 into FibreFoX:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants