Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got inspired when seeing #39, after that is fixed, these were the main sources of time spent in the translation.
@time load_msh()
goes from0.250281 seconds (264.77 k allocations: 17.653 MiB)
to0.190106 seconds (36.86 k allocations: 10.099 MiB)
without #39 (with #39, the relative change is more significant and almost all time is spent ingmsh.open
).