[X-PR] p4est/p8est face transformation fix #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mk/p4est #890 +/- ##
============================================
- Coverage 34.85% 31.48% -3.38%
============================================
Files 35 35
Lines 5778 5870 +92
============================================
- Hits 2014 1848 -166
- Misses 3764 4022 +258 ☔ View full report in Codecov by Sentry. |
koehlerson
reviewed
Mar 7, 2024
Co-authored-by: Maximilian Köhler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not mess around with the PR's state here is a separate PR which proposes a fix for the face transformation. Probably some downstream implementations will break and will require further intervention.
TODO