Default to Lagrange{refdim,refshape,1}()
for geometric mapping
#695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the default value for the geometric mapping in
(Cell|Face)(Scalar|Vector)Values
to linear Lagrange interpolationinstead of (re)using the function interpolation. This decouples these
two concepts further.
Some "real world" examples where I think this new default is more sane,
and the current default is just a stumbling block:
Consider the following code with linear cells:
To update this to use e.g. a quadratic approximation one currently
have to change more than just the approximation order, i.e. one has
to use
instead of simply
For the Taylor-Hood element one always have to worry about the
geometric mapping, regardless if it is linear or quadratic:
instead of just
For more exotic elements, such as
VectorizedInterpolation
(Implement(Scalar|Vector)Interpolation
andVectorizedInterpolation{<:ScalarInterpolation}
#694),or
RaviartThomas
it is also a more useful default.