Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Ferrite.ndim(dh, fieldname) #658

Merged
merged 2 commits into from
Mar 31, 2023
Merged

remove Ferrite.ndim(dh, fieldname) #658

merged 2 commits into from
Mar 31, 2023

Conversation

kimauth
Copy link
Member

@kimauth kimauth commented Mar 31, 2023

As the diff shows this was almost unused and also duplicate functionality of getfielddim.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (3baab3e) 92.99% compared to head (f7c05a7) 92.99%.

❗ Current head f7c05a7 differs from pull request most recent head 4c2636b. Consider uploading reports for the commit 4c2636b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   92.99%   92.99%   -0.01%     
==========================================
  Files          30       30              
  Lines        4497     4496       -1     
==========================================
- Hits         4182     4181       -1     
  Misses        315      315              
Impacted Files Coverage Δ
src/Dofs/DofHandler.jl 84.15% <ø> (-0.09%) ⬇️
src/Dofs/ConstraintHandler.jl 95.84% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kimauth kimauth merged commit a350434 into master Mar 31, 2023
@kimauth kimauth deleted the ka/deprecate_ndim branch March 31, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants