Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apply_analytical! function #532
Add apply_analytical! function #532
Changes from 18 commits
0b22bcc
8ef8b48
3320f89
161a357
b72ff7b
027eb41
5d5b93f
c96b88b
269d867
e327d75
106f049
2887dc5
15d12d8
3957086
9203026
129e8c3
faffed0
e95ac23
7714b89
3d3165b
9b7d775
8e1baf0
ebca08b
a599d05
28863d8
1170e4f
0ea6420
cecbdfb
b49bf62
976e5ba
51d3f7e
c574a06
7f7b929
450e9c5
cacce2f
211c8ac
494a2e1
10a7922
f95c6df
2166d14
a9bef3d
1bd56ae
6e64ff8
cc92f33
da7e532
60e3cb4
4f85093
3387146
b736685
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think other examples use https://github.com/jipolanco/WriteVTK.jl/blob/6e528bd6a016efb84f5cb50f2dc43bcdc59ab8d4/src/gridtypes/ParaviewCollection.jl#L59 but since I don't see that in the WriteVTK documentation maybe it is deprecated or discouraged? Edit: I see that this approach was also used later in this file, so let's at least have it consistent (if you change here, also change below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen
collection_add_timestep
before. What example did you think of?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My research code I guess :D I thought we had some other time dependent problems. It used to be the only advertised way before, but maybe that has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JuliaVTK/WriteVTK.jl#113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only true for index 1 DAEs. For index>1 you get hidden constraints which must be fulfilled too. This makes the initialization so tricky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something like this then?
(I think I'll change from
x
toa
for the unknowns later, just to avoid confusion with the coordinate)