-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe Navier-Stokes Diffeq example mesh by gmsh api usage and translate via FerriteGmsh #498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 36 36
Lines 5441 5441
=======================================
Hits 5101 5101
Misses 340 340 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might work.
@fredrikekre mesh from stokes example chokes 🤔 |
aaefd4b
to
a557759
Compare
I could not reproduce the vortex street with the updated mesh, but it's very likely not a problem with the mesh itself |
To elaborate on the likely issue: The solution for the formulation is not unique up to a constant value in the pressure. For the currently used mesh with equisized elements the linear solvers seems to not have trouble finding a close sequence of constants. We should fix this with the trick from the stokes example, where we force the constant to a proper value by setting the boundary integral of the pressure to zero. Does not seem to be super straight forward in this example. |
… is no vortex stream for the fine mesh, which is probably not a mesh reason
Can we make the grid generation deterministic? |
I could find several open issues.
I will push the fixes for 1,2,5 later today, after commenting everything. This should then make the PR ready to merge. |
Also as a future project idea: 3D Navier Stokes with MPI parallelization in tandem with OrdinaryDiffEq. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final changes and this should be good to go.
Co-authored-by: Dennis Ogiermann <[email protected]>
Should be ready transiently through #917 . |
* Tryi Fixi * Dep * Reproducer. * Manifest. * Finally fix the Navier-Stokes solver. At least partially. * Dump other examples. * fix tag numbers of rectangle curves from occ * Fix example and recover vortex street. * Revert * Revert manifest * Remove trailing message. * Update docs/src/literate-tutorials/ns_vs_diffeq.jl Co-authored-by: Maximilian Köhler <[email protected]> * Apply suggestions from code review Co-authored-by: Maximilian Köhler <[email protected]> * Format. * Tweaks * Fixed. Now we just need to wait for the next OrdinaryDiffEq release. * Add new DiffEq release. --------- Co-authored-by: Maximilian Köhler <[email protected]> Co-authored-by: termi-official <[email protected]>
xref SciML/OrdinaryDiffEq.jl#2238 the information needs to be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Maxi! I will update the example to use the TimeChoiceIterator in a separate PR later after the interpolation issue in DifferentialEquations.jl is resolved.
Last commit broke the gif :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
Need to include an optional finer discretization with vortex street. Currently only coarse discretization for CI is in the literate file. Will test around when I'm back at my workstation