Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic Nirvana #481

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Periodic Nirvana #481

merged 1 commit into from
Sep 22, 2022

Commits on Sep 22, 2022

  1. Periodic Nirvana

    This patch fixes most remaining issues with periodic constraints:
    
     - collect_periodic_faces now return Vector{PeriodicFacePair} instead of
       Dict{Int,Int}. This is necessary since, in 3D, we need to keep track of
       i) the relative rotation between the faces and ii) if they are mirrored
       (opposing normal vectors) or not
     - Several bugs related to 3D periodicities and rotation/mirroring have
       been fixed
     - Numbering for quadratic interpolation for 3D cubes have been fixed to
       match the rest of Ferrite. The added tests for periodic constraints
       revealed this issue
    
    With this patch, periodic constraints should work fine for linear
    and quadratic interpolations for and all supported cell types in both 2
    and 3 dimensions.
    fredrikekre committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b885758 View commit details
    Browse the repository at this point in the history