Periodic Nirvana #481
Merged
Periodic Nirvana #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any examples that use periodic B.C yet? |
fredrikekre
force-pushed
the
fe/collect-periodic
branch
from
959c3ef
to
114c1a3
Compare
fredrikekre
force-pushed
the
fe/collect-periodic
branch
from
114c1a3
to
9c13b52
Compare
Codecov ReportBase: 91.57% // Head: 91.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 91.57% 91.90% +0.33%
==========================================
Files 22 22
Lines 3547 3644 +97
==========================================
+ Hits 3248 3349 +101
+ Misses 299 295 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This patch fixes most remaining issues with periodic constraints:
- collect_periodic_faces now return Vector{PeriodicFacePair} instead of
Dict{Int,Int}. This is necessary since, in 3D, we need to keep track of
i) the relative rotation between the faces and ii) if they are mirrored
(opposing normal vectors) or not
- Several bugs related to 3D periodicities and rotation/mirroring have
been fixed
- Numbering for quadratic interpolation for 3D cubes have been fixed to
match the rest of Ferrite. The added tests for periodic constraints
revealed this issue
With this patch, periodic constraints should work fine for linear
and quadratic interpolations for and all supported cell types in both 2
and 3 dimensions.
fredrikekre
force-pushed
the
fe/collect-periodic
branch
from
9c13b52
to
b885758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes most remaining issues with periodic constraints:
With this patch, periodic constraints should work fine for linear and quadratic interpolations for and all supported cell types in both 2 and 3 dimensions.